fix: gentool config file ignored bug #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @qqxhb You made a fix in #942 that relates to this PR.
I think you need to fix either the README or the implementation. Sorry for my bad English. |
|
@yama-6 没关系，我们可以中文交流。 |
|
@qqxhb I understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Before the fix
Part of the content of the gentool configuration file is ignored. This is because the default values set in the command line arguments take priority over them.
Example
Update
gen.yml. Set the value ofdbtopostgres.If you could output the logs you would see that, the value of
dbis executed asmysql. This is because the default value of the command-line arguments is given priority.After the fix
The content of the gentool configuration file will be reflected. However, if command-line arguments are specified, they will be given priority. This behavior is the same as before the fix.